Skip to content

P2876R3 Proposal to extend std::simd with more constructors and accessors #7997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

mattkretz
Copy link
Member

\pnum
\expects
\begin{itemize}
\item \tcode{size()} $\le N$, or
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why you've decided to change what is in the paper via fix-up here. We have tons of wording precedent for

x < y is true

... as dumb as it sounds, but to my knowledge, we don't have any kind of formal decision that would eliminate this. LWG approved this wording, so we may as well keep it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it because that's more consistent with what's in [simd] (i.e., what we did for P1928). I wanted to call that out as a questionable commit / a suggestion and forgot about it.
Better to drop it then?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot answer with authority, but we have procedures in https://github.com/cplusplus/draft/wiki/Applying-papers-to-the-Working-Draft for this. To my understanding, we only use commits in the same PR for typo repairs and other things that are broken in the paper wording.

If there are stylistic/consistency improvements, those tend to go onto into a separate PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed the commit from my Motions 10–13 PR and will submit a separate PR.

@mattkretz
Copy link
Member Author

Moved to new PR

@mattkretz mattkretz closed this Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants